Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql,gcjob: enable declarative schema changer in drop tests #79294

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 3, 2022

Backport 1/1 commits from #79119 on behalf of @ajwerner.

/cc @cockroachdb/release


A couple of these tests were just fully rotted. A lot of them are close but
easy enough to carry along.

Fixes #78030.

Release note: None


Release justification: low-risk test improvements

@blathers-crl blathers-crl bot requested a review from a team April 3, 2022 18:25
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-79119 branch from 9a26ccc to 7edb3d5 Compare April 3, 2022 18:26
@blathers-crl blathers-crl bot requested a review from postamar April 3, 2022 18:26
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 3, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 3, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar force-pushed the blathers/backport-release-22.1-79119 branch from 7edb3d5 to cb0f158 Compare April 11, 2022 18:40
A couple of these tests were just fully rotted. A lot of them are close but
easy enough to carry along.

Fixes #78030.

Release note: None
@ajwerner ajwerner force-pushed the blathers/backport-release-22.1-79119 branch from cb0f158 to 6d71326 Compare April 11, 2022 19:14
@postamar postamar merged commit 3c9a373 into release-22.1 Apr 11, 2022
@postamar postamar deleted the blathers/backport-release-22.1-79119 branch April 11, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants