Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanconfig: ensure single reconciliation job post-restore #79222

Conversation

irfansharif
Copy link
Contributor

Fixes #70173. When restoring a cluster, we don't want to end up with two
instances of the singleton reconciliation job.

Release note: None


First commit is from #79139.

@irfansharif irfansharif requested review from dt and adityamaru April 1, 2022 12:51
@irfansharif irfansharif requested review from a team as code owners April 1, 2022 12:51
@irfansharif irfansharif requested a review from a team April 1, 2022 12:51
@irfansharif irfansharif requested a review from a team as a code owner April 1, 2022 12:51
@irfansharif irfansharif requested review from gh-casper and removed request for a team and gh-casper April 1, 2022 12:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Fixes cockroachdb#70173. When restoring a cluster, we don't want to end up with two
instances of the singleton reconciliation job.

Release note: None
@irfansharif irfansharif force-pushed the 220401.dup-reconciliation-job branch from 2499d82 to 888543f Compare April 1, 2022 12:55
irfansharif added a commit to irfansharif/cockroach that referenced this pull request Apr 1, 2022
Closes cockroachdb#75060; speculating that cockroachdb#79222 fixed the underlying issue.
Previously the reconciliation job errored out with "expected to delete
11 row(s), deleted 10", which could conceivably occur if there were two
instances of the reconciliation job running post-restore (something
\cockroachdb#79222 fixes).

Release note: None
@irfansharif
Copy link
Contributor Author

David ended up reviewing this as part of #79228, just going to run with it.

@irfansharif irfansharif closed this Apr 1, 2022
@irfansharif irfansharif deleted the 220401.dup-reconciliation-job branch April 1, 2022 18:54
craig bot pushed a commit that referenced this pull request Apr 1, 2022
79228: backupccl: run TestFullClusterBackup with span configs r=irfansharif a=irfansharif

Closes #75060; speculating that #79222 fixed the underlying issue.
Previously the reconciliation job errored out with "expected to delete
11 row(s), deleted 10", which could conceivably occur if there were two
instances of the reconciliation job running post-restore (something
\#79222 fixes).

Release note: None

---

First two commits are from #79139 and #79222 respectively.

Co-authored-by: David Taylor <tinystatemachine@gmail.com>
Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanconfig: AUTO SPAN CONFIG job does not handle duplicate after being restored
3 participants