-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv/bulk: send ssts with lower admission control priority #79126
Conversation
dfe62ce
to
269d48b
Compare
Reelase note: none.
first two commits are #79086, ignore them here. |
passing args/unpacking returns is getting annoying. Release note: none.
The detour through the kv.DB wrapper was just adding more plumbing, signatures, etc to update to get an argument or return value through. Perhaps we should remove them in a follow-up as this is the only non-test caller. Release note: none.
Release note (performance improvement): Bulk ingestion writes now use a lower priority for admission control.
Agreed, I find the non-trivial |
I'm a little wary about back-porting this so last minute, particularly given how much recent ingestion performance work we've been doing, so hopefully we can get it in asap so it has at least a few betas in which to bake. |
I'm fine with merging this as-is. |
👍 was just waiting on the open questions in #79086. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the admission control bits
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, 1 of 2 files at r4, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
TFTRs! bors r+ |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ef29359 to blathers/backport-release-21.2-79126: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
blathers backport 21.2 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ef29359 to blathers/backport-release-21.2-79126: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
small refactor while I'm here since plumbing args to/from the kv.DB "helpers" has been a source of toil and merge conflicts lately.
Jira issue: CRDB-14737
Epic CRDB-2264