roachtest: exit 11 after cluster provisioning failures #78633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`roachtest` exits nonzero if it was unable to run any tests due to cloud flakiness (resource exhaustion etc). Previously the "nonzero" was 1 which is the catchall exit code. Now it uses 11 which can now signal this specific failure mode, and could be special cased in our CI scripts if we so desire in the future. Release note: None
|
This change is |
srosenberg
approved these changes
Mar 28, 2022
complete! 1 of 0 LGTMs obtained
|
bors r=srosenberg |
|
Build succeeded: |
|
blathers backport 22.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roachtestexits nonzero if it was unable to run any tests due to cloudflakiness (resource exhaustion etc). Previously the "nonzero" was 1
which is the catchall exit code. Now it uses 11 which can now signal
this specific failure mode, and could be special cased in our CI scripts
if we so desire in the future.
Release note: None