-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.2: [CRDB-3303] ui: handle latency not defined on network page #78627
Conversation
Previously when a cluster with multiple nodes had a node stopped and then another node quickly started, the network page would crash. This was due to the node object holding the latency value being undefined and the ui trying to read this key when that was undefined. This occurs when a node is in an `UNAVAILABLE` state. This patch resolves the issue by being more defensive on the front end by safely attempting to access latency and if it is undefined, set the value to 0. The existing code is able to handle this case afterward and will eventually set the user friendly latency status to `--`. Resolves: #59322 Release note (ui change): Fixes a bug where a node in the `UNAVAILABLE` state will not have latency defined and cause the network page to crash.
884bb19
to
bac6474
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @koorosh)
Backport 1/1 commits from #78292 on behalf of @Santamaura.
/cc @cockroachdb/release
Previously when a cluster with multiple nodes had a node stopped
and then another node quickly started, the network page would crash.
This was due to the node object holding the latency value being
undefined and the ui trying to read this key when that was undefined.
This occurs when a node is in an
UNAVAILABLE
state.This patch resolves the issue by being more defensive on the front
end by safely attempting to access latency and if it is undefined,
set the value to 0. The existing code is able to handle this case
afterward and will eventually set the user friendly latency status
to
--
.Resolves: #59322
Release note (ui change): Fixes a bug where a node in the
UNAVAILABLE
state will not have latency defined and cause thenetwork page to crash.
Overview list page & network page when node status is
UNAVAILABLE
:Release justification: 1 Line change for very useful bug fix