-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week -1: follow-up emails #78595
Week -1: follow-up emails #78595
Conversation
a8043c3
to
d8fbaca
Compare
Hi @rail - I thought I could get these emails up in time for us to run today's "Monday emails" step, but the new parameters don't seem to be wired up correctly 🤔 . See failed attempts: Maybe we can chat about this further in today's weekly release meeting. |
d8fbaca
to
4f7f047
Compare
6b3c8f0
to
c61401b
Compare
Hi @rail - I just squashed -- this is RFAL whenever you have a moment, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 42 of 42 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @celiala)
This PR adds follow-up emails for: the day before PrepDate (to be sent if only there are still blockers) the day of PrepDate (to be sent if only there are still blockers) the day after PrepDate (to be sent if only there are still blockers) Release note (<category, see below>): <what> <show> <why>
c61401b
to
e6ddbf7
Compare
TFTR! bors r=rail |
Build succeeded: |
This PR adds follow-up emails for:
PrepDate
(to be sent if only there are still blockers)PrepDate
(to be sent if only there are still blockers)PrepDate
(to be sent if only there are still blockers)The
post-blockers
command should be used for all emails before and up toPrepDate
:The
cancel-release-date
should be used for the day afterPrepDate
email:TeamCity changes
This will be paired with the following TeamCity jobs:
Manual tests
Test 1: post-blockers --days-before-prep-date many-days
Test 2: post-blockers --days-before-prep-date day-before
Test 3: post-blockers --days-before-prep-date day-of
Test 4: cancel-release-date