Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: roachtest: wait for ranges to replicate before filling disk #78538

Merged
merged 2 commits into from
Mar 28, 2022
Merged

release-22.1: roachtest: wait for ranges to replicate before filling disk #78538

merged 2 commits into from
Mar 28, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 25, 2022 •
edited by nicktrav
Loading

Backport 1/1 commits from #78456 on behalf of @nicktrav.

/cc @cockroachdb/release

Currently, the disk-full roachtest creates a cluster and immediately
places a ballast file on one node, which causes it to crash. If this
node is the only replica for a range containing a system table, when the
node crashes due to a full disk certain system queries may not complete.
This results in the test being unable to make forward progress, as the
one dead node prevents a system query from completing, and this query
prevents the node from being restarted.

Wait for all ranges to have at least two replicas before placing the
ballast file on the one node.

Closes #78337.

Release note: None.

Release justification: Test only.

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-78456 branch from fe64189 to c22a047 Compare March 25, 2022 23:34
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 25, 2022 •
edited by nicktrav
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from itsbilal, jbowens, nicktrav and tbg March 25, 2022 23:34
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 25, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

nicktrav added 2 commits March 28, 2022 11:33
@nicktrav
roachtest: wait for ranges to replicate before filling disk
c3cc431 
Currently, the `disk-full` roachtest creates a cluster and immediately
places a ballast file on one node, which causes it to crash. If this
node is the only replica for a range containing a system table, when the
node crashes due to a full disk certain system queries may not complete.
This results in the test being unable to make forward progress, as the
one dead node prevents a system query from completing, and this query
prevents the node from being restarted.

Wait for all ranges to have at least two replicas before placing the
ballast file on the one node.

Touches #78337, #78270.

Release note: None.
@nicktrav
roachtest: wait for 3x replication in disk-full
554629c 
Improve on #78456 by waiting fro 3x replication, rather than 2x.

Release note: None.
@nicktrav nicktrav force-pushed the blathers/backport-release-22.1-78456 branch from c22a047 to 554629c Compare March 28, 2022 18:34
@nicktrav
Copy link
Collaborator

@tbg - included the additional commit.

jbowens
jbowens approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @itsbilal, @nicktrav, and @tbg)

@nicktrav
Copy link
Collaborator

TFTR!

@nicktrav nicktrav merged commit 2a7d05c into release-22.1 Mar 28, 2022
@nicktrav nicktrav deleted the blathers/backport-release-22.1-78456 branch March 28, 2022 20:13
@nicktrav nicktrav mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg left review comments

@jbowens jbowens jbowens approved these changes

@itsbilal itsbilal Awaiting requested review from itsbilal

@nicktrav nicktrav Awaiting requested review from nicktrav

Assignees

@nicktrav nicktrav

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @nicktrav @jbowens @tbg