workload: support fixture import in multi-tenant mode #78418
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/ccl/workloadccl/fixture.go, line 358 at r1 (raw file):
// If the query is unsupported because we're in multi-tenant mode. Assume // that the cluster has 1 node for the purposes of running CSV servers. // Tenants won't use DistSQL to parallelize IMPORT across SQL pods.
Can you file a follow-up issue, link its ID from this comment, then label that issue with A-multi-tenancy and ping adam on it. Thanks
Fixes cockroachdb#75449. This commit fixes fixture import into tenants, which do not have access to the `crdb_internal.gossip_liveness` table. This fixes the following: - `[cockroach] workload fixtures import` - `[cockroach] workload init --data-loader=IMPORT` Release justification: low-risk change that improves workload functionality.
nvanbenschoten
force-pushed
the
nvanbenschoten/mtImport
branch
from
e38b65d to
11d9b3d
Compare
nvanbenschoten
commented
Mar 29, 2022
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/ccl/workloadccl/fixture.go, line 358 at r1 (raw file):
Previously, knz (kena) wrote…
Can you file a follow-up issue, link its ID from this comment, then label that issue with A-multi-tenancy and ping adam on it. Thanks
Done in #78968.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75449.
This commit fixes fixture import into tenants, which do not have access to the
crdb_internal.gossip_livenesstable. This fixes the following:[cockroach] workload fixtures import[cockroach] workload init --data-loader=IMPORTRelease justification: low-risk change that improves workload functionality.