Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: clean up disabling of auto stats #78256

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

yuzefovich
Copy link
Member

All logic test configs currently override the auto stats collection to
be disabled, and this commit makes it explicit. Additionally, it removes
the explicit statements from the tests themselves for disabling the
stats collection.

Release note: None

All logic test configs currently override the auto stats collection to
be disabled, and this commit makes it explicit. Additionally, it removes
the explicit statements from the tests themselves for disabling the
stats collection.

Release note: None
@yuzefovich yuzefovich requested review from msirek, michae2 and a team March 22, 2022 15:24
@yuzefovich yuzefovich requested a review from a team as a code owner March 22, 2022 15:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @msirek)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 22, 2022

Build succeeded:

@craig craig bot merged commit e02793d into cockroachdb:master Mar 22, 2022
@yuzefovich yuzefovich deleted the stats-override branch March 22, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants