ccl/sqlproxyccl: add basic Balancer component for load balancing #78156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory Previously, --routing-rule is used as a fallback resolution if a tenant cannot be found from the directory. Note that we no longer need this on Cloud. This commit addresses a TODO comment by moving the resolution rule implementation into a simple directory. The plan is to replace the tenant.Resolver interface with a tenant.Directory interface. The existing tenant.Directory struct will be renamed to tenant.serviceDirectory. For now, there will be two types of directory implementations: simple directory (a single rule), and service directory (one that connects to a GRPC server). There are plans to add a static directory (perhaps backed by a config file) which will enable roachprod to use sqlproxy in a multi-tenant setup. This TODO is also a pre-req to the load balancing work for sqlproxy. Without that addressed, maintaining a routing rule for the balancing work can be non-trivial. Release note: None
This commit addresses one of the TODOs to make tenant.Directory a generic interface instead of a struct. For that to work, we'd have to rename the existing Directory struct. This is purely a mechanical commit. Release note: None
Previously, all directory related files are located in a tenant package, which can be confusing. This commit moves files into specific directories, and is purely mechanical. Release note: None
This commit completes the work of making tenant.Directory an interface. Since we have renamed the previous Directory struct into a serviceDirectory struct, we can now use Directory as an interface for what was previously known as the resolver. Release note: None
|
This change is |
This commit adds a basic Balancer component that is responsible for load balancing connections across SQL pods. This commit updates the connector component to invoke methods on the balancer when selecting a pod instead of the tenant directory. For now, the balancer does nothing specific, and invokes methods on the directory. Release note: None
jaylim-crl
force-pushed
the
jay/add-basic-balancer
branch
from
bdcb0b8 to
fd3c5be
Compare
jaylim-crl
requested review from
jeffswenson and
andy-kimball
and removed request for
a team
|
Superseded by #78396. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only review the last commit. The first four are in #78143.
This commit adds a basic Balancer component that is responsible for load
balancing connections across SQL pods. This commit updates the connector
component to invoke methods on the balancer when selecting a pod instead of
the tenant directory. For now, the balancer does nothing specific, and
invokes methods on the directory.
Release note: None