-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: integrate new cross toolchains w/ Bazel #77960
Conversation
0d3b273
to
f3cd661
Compare
518bd8c
to
beb9d80
Compare
beb9d80
to
4bbb9a1
Compare
1. Add new toolchains that run on ARM hosts. 2. Add new toolchains that target M1 Mac's. Release note: None
4bbb9a1
to
68355af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! :D Woohoo, ARM builds!!
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
build/toolchains/crosstool-ng/toolchain.bzl, line 4 at r1 (raw file):
if rctx.attr.host == "x86_64": url = "https://storage.googleapis.com/public-bazel-artifacts/toolchains/crosstool-ng/{}/20220317-191459/{}.tar.gz".format(rctx.attr.host, rctx.attr.target) elif rctx.attr.host == "aarch64":
Just for my curiosity's sake, why the different URL for aarch64? Not supported in the most recent release yet?
c-deps/BUILD.bazel, line 17 at r1 (raw file):
"@io_bazel_rules_go//go/platform:darwin_arm64": [ "--host=aarch64-apple-darwin21.2", "--with-lg-page=16",
Hmmm, why do we need this for arm and not for anything else?
c-deps/BUILD.bazel, line 186 at r1 (raw file):
"//build/toolchains:cross": { "AUTOM4TE": "$(execpath :autom4te)", "krb5_cv_attr_constructor_destructor": "yes",
Why the changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
To build these toolchains I ran the CI script twice, once on a normal x86_64 agent and once on an ARM agent. The script is written to use the value of
Our
Adding the line back gets rid of it.
This helps |
bors r=mari-crl |
Build succeeded: |
Release note: None
Jira issue: CRDB-14852