Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: --rewrite should imply --ignore-cache #77784

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

rickystewart
Copy link
Collaborator

If you meant to rewrite again but didn't update any source files, Bazel
can reuse the cached results which is confusing.

Release justification: Non-production code changes
Release note: None

@rickystewart rickystewart requested a review from a team as a code owner March 14, 2022 17:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to dev testlogic as well. Do we need to update testdata files?

pkg/cmd/dev/test.go Outdated Show resolved Hide resolved
If you meant to rewrite again but didn't update any source files, Bazel
can reuse the cached results which is confusing.

Release justification: Non-production code changes
Release note: None
@rickystewart
Copy link
Collaborator Author

Applies to dev testlogic as well. Do we need to update testdata files?

Fixed both of these.

@rickystewart
Copy link
Collaborator Author

bors r=irfansharif

@craig
Copy link
Contributor

craig bot commented Mar 15, 2022

Build succeeded:

@craig craig bot merged commit eed2f30 into cockroachdb:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants