ci: add bazel-based script for roachtest release qualification #77681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
roachtestreleasequal
branch
from
96fcc04 to
2a14184
Compare
rail
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
build/teamcity/internal/release/process/roachtest-release-qualification.sh, line 63 at r1 (raw file):
--parallelism 5 \ --teamcity; then exit_status=$?
A nit: it doesn't look like the if clause helps here. We can probably get rid of exit_status and run the command directly.
This is essentially a copy of the content we have in TC for this build configuration, but with the `make`-specific logic replaced with Bazel logic. The build configuration will be updated to check for the existence of this script and run it if it's present, otherwise run the old logic. Closes cockroachdb#67337. Release justification: Update release qualification roachtests Release note: None
rickystewart
force-pushed
the
roachtestreleasequal
branch
from
2a14184 to
cd8c27a
Compare
|
bors r=rail |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a copy of the content we have in TC for this build
configuration, but with the
make-specific logic replaced with Bazellogic.
The build configuration will be updated to check for the existence of
this script and run it if it's present, otherwise run the old logic.
Closes #67337.
Release justification: Update release qualification roachtests
Release note: None