sql/contention: introduce contention duration threshold cluster setting #77623
Conversation
|
This change is |
There was a problem hiding this comment.
Small nit and make sure tests pass, otherwise
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @Azhng and @maryliag)
pkg/sql/contention/cluster_settings.go, line 44 at r1 (raw file):
settings.TenantWritable, "sql.contention.event_store.duration_threshold", "minimum contention duration to cause the contention events to be collected "+
nit: add the unit, e.g. ...duration in milliseconds to cause...
There was a problem hiding this comment.
Reviewable status:
pkg/sql/contention/cluster_settings.go, line 44 at r1 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
nit: add the unit, e.g.
...duration in milliseconds to cause...
Hmm it's a bit hard to state a unit here since it's a "duration" cluster setting. It's able to parse the unit from user input. (e.g. user can do '10m' or '10s')
There was a problem hiding this comment.
Reviewable status:
pkg/sql/contention/cluster_settings.go, line 44 at r1 (raw file):
Previously, Azhng (Archer Zhang) wrote…
Hmm it's a bit hard to state a unit here since it's a "duration" cluster setting. It's able to parse the unit from user input. (e.g. user can do
'10m'or'10s')
Got it, when I saw the 0 I though the user would set just the number without the unit. Sounds good 👍
|
TFTR! bors r=maryliag |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
From the failed bors attempts. Is it due to this PR? bors r- |
|
Canceled. |
This introduces sql.contention.event_store.duration_threshold cluster setting. This cluster setting specifies the minimum contention duration to cause the contention events to be collected into crdb_internal.transaction_contention_events virtual table. This cluster setting has the default value of 0. Release justification: low risk high reward changes Release note (sql change): introduce sql.contention.event_store.duration_threshold cluster setting. This cluster setting specifies the minimum contention duration to cause the contention events to be collected into crdb_internal.transaction_contention_events virtual table.
|
Sorry about that, rebased. |
|
bors r=maryliag |
|
Build succeeded: |
This introduces sql.contention.event_store.duration_threshold cluster
setting. This cluster setting specifies the minimum contention duration
to cause the contention events to be collected into
crdb_internal.transaction_contention_events virtual table. This cluster
setting has the default value of 0.
Release justification: low risk high reward changes
Release note (sql change): introduce
sql.contention.event_store.duration_threshold cluster setting. This
cluster setting specifies the minimum contention duration to cause
the contention events to be collected into
crdb_internal.transaction_contention_events virtual table.