kv: Add created column to active_range_feeds table.
#77597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
| StartTS: startFrom, | ||
| Span: span, | ||
| StartTS: startFrom, | ||
| EstablishedTime: timeutil.Now(), |
There was a problem hiding this comment.
I'm not sure what exactly we want the semantics of this field to be, but maybe we should set it whenever the rangefeed is actually established, i.e. when we get a nil error back from client.RangeFeed()? At least to me, "established" implies that the rangefeed connection was successfully set up. I guess that also implies that it would get updated if we ever disconnect or reconnect too.
Alternatively, we could consider calling this Created and use Established as a separate field.
There was a problem hiding this comment.
Ack... I was going back and forth w/ established v created. Changing to created.
erikgrinaker
approved these changes
Mar 10, 2022
miretskiy
changed the title
established column to active_range_feeds table.created column to active_range_feeds table.
Add `created` column to `active_range_feeds` table. This column is initialized to the time when the partial range feed was created. This allows us to determine, among other things, whether or not the rangefeed is currently performing a catchup scan (i.e. it's resolved column is 0), and how long the scan has been running for. Release Notes (enterprise): Add created time column to `crdb_internal.active_range_feeds` virtual table to improve observability and debugability of rangefeed system. Release Justification: Low impact observability/debugability improvement.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
createdcolumn toactive_range_feedstable.This column is initialized to the time when the partial range feed
was created. This allows us to determine, among other things,
whether or not the rangefeed is currently performing a catchup scan
(i.e. it's resolved column is 0), and how long the scan has been running
for.
Release Notes (enterprise): Add created time column
to
crdb_internal.active_range_feedsvirtual table to improve observabilityand debugability of rangefeed system.
Fixes #77581
Release Justification: Low impact observability/debugability improvement.