sql/contention/txnidcache: avoid recording nil txnID #77502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Can you add tests for this case?
Reviewable status:
complete! 0 of 0 LGTMs obtained
Resolves cockroachdb#77371 Previously, there are edge cases where the txnID in the resolvedTxnID emitted from connExecutor will be nil, (e.g. when the connExecutor closes while a transaction is still active). Writing invalid txnID into the writer can potentially cause data loss, since the TxnID cache stops processing the input batch when it encounters the first invalid txnID. This commit prevents invalid txnID from being written into TxnID Cache. Release justification: bug fix to existing functionality Release note: None
|
Test added. |
maryliag
approved these changes
Mar 9, 2022
|
TFTR! bors r=maryliag |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #77371
Previously, there are edge cases where the txnID in the resolvedTxnID
emitted from connExecutor will be nil, (e.g. when the connExecutor closes
while a transaction is still active). Writing invalid txnID into the
writer can potentially cause data loss, since the TxnID cache stops
processing the input batch when it encounters the first invalid txnID.
This commit prevents invalid txnID from being written into TxnID Cache.
Release justification: bug fix to existing functionality
Release note: None