sql: make session_revival_token.enabled tenant-ro #77493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
session-revival-tenant-read-only
branch
from
85a71ae to
c30c7b9
Compare
jaylim-crl
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RichardJCai)
jaylim-crl
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Also, looks like the logic tests failed:
pq: relation "system.tenant_settings" does not exist
Reviewable status:
otan
approved these changes
Mar 8, 2022
I was hoping to wait for the new cluster setting syntax to be completed, but since it's getting close to the branch cut time I'd rather merge this now so we don't forget at the last minute. Release justification: low risk change to new functionality. Release note: None
rafiss
force-pushed
the
session-revival-tenant-read-only
branch
from
c30c7b9 to
b877524
Compare
|
tftr! bors r=otan,jaylim-crl |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to wait for the new cluster setting syntax to be completed,
but since it's getting close to the branch cut time I'd rather merge
this now so we don't forget at the last minute.
Release justification: low risk change to new functionality.
Release note: None