sqlproxyccl: Add codeUnavailable to the list of error codes

[alyshanjahani-crl]

Release justification: fixes for high-priority bug in existing functionality

Previously, if a tenant cluster had maxPods set to 0 the error returned by
directory.EnsureTenantAddr was not treated as a non-retryable error.

The tenant directory implementation used in CockroachCloud now identifies
this situation and returns a status error with codes.FailedPrecondition and
a descriptive message.

This patch adds a check for the FailedPrecondition error in
connector.lookupAddr.

Release note: None

[cockroach-teamcity]

This change is 

[jeffswenson]

If we are unable to retrieve the status, we should still return a codeUnavailable error and break from the loop. I'm worried this case could trigger an infinite loop.

[jeffswenson]

nit: it would be nice to flatten this logic. I'm thinking something like

switch {
case err == nil:
  return add, nil
case status.Code(err) == codes.FailedPrecondition:
  message = "unavailable"
  if st, ok := status.FromError(err); ok {
    message = st.Message()
  }
  return "", newErrorf(codeUnavailable, st.Message()
case status.Code(err) != codes.NotFound:
  return "", markAsRetriableConnectionError(err)
default: 
  /* fallback to old resolution rule */
}

[alyshanjahani-crl]

Do you know how I go about generating errorcode_string.go it says it is generated by "stringer". Since i've added codeUnavailable i need to re-generate this file.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @jeffswenson)

---

pkg/ccl/sqlproxyccl/connector.go, line 323 at r1 (raw file):

Previously, JeffSwenson (Jeff Swenson) wrote…

If we are unable to retrieve the status, we should still return a codeUnavailable error and break from the loop. I'm worried this case could trigger an infinite loop.

Done.

[jeffswenson]

LGTM

You can use dev to regenerate errcode_string.go

./dev generate

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @jeffswenson)

[jaylim-crl]

without the release note. SQL proxy is internal only for now, so no release notes are needed.

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jeffswenson)

[alyshanjahani-crl]

SQL proxy is internal only for now, so no release notes are needed.

Ack, amended the commit msg to remove release note.

TFTR

[jaylim-crl]

We would sill want Release note: None 😄 Same to PR message I think.

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @jeffswenson)

[alyshanjahani-crl]

haha, thx for the quick response ;)
Done.

[alyshanjahani-crl]

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating backport branch refs/heads/blathers/backport-release-21.2-77442: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch 21.2.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}

[alyshanjahani-crl]

blathers backport 21.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating backport branch refs/heads/blathers/backport-release-21.2-77442: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch 21.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}