backupccl: test ignore ProtectionPolicy for exclude_data_from_backup #77406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
commented
Mar 5, 2022
| // TestExcludeDataFromBackupDoesNotHoldupGC tests that a table marked as | ||
| // `exclude_data_from_backup` and with a protected timestamp record covering it | ||
| // does not holdup GC, since its data is not going to be backed up. | ||
| func TestExcludeDataFromBackupDoesNotHoldupGC(t *testing.T) { |
There was a problem hiding this comment.
I solemnly swear to datadriven-ify these tests as part of #77129, but to derisk this change I wanted to postpone building out our backup datadriven framework. I have ideas on how to wrap all these GC/SpanConfig operations that I'll work on as part of our test revamp.
adityamaru
force-pushed
the
ignore-pts-records-2
branch
from
d7a01a4 to
5fb8960
Compare
This change adds an end to end test to ensure that a table excluded from backup will not holdup GC on its replica even in the presence of a protected timestamp record covering the replica From a users point of view, this allows them to mark a table whose row data will be excluded from backup, and to set that tables gc.ttl to a very low value. Backups that write PTS records will no longer holdup GC on such low GC TTL tables. Fixes: cockroachdb#73536 Release note: None Release justification: low risk update to new functionality
adityamaru
force-pushed
the
ignore-pts-records-2
branch
from
5fb8960 to
3470def
Compare
adityamaru
changed the title
|
@irfansharif removing this from your review queue since this has become a test only change after #77392. This is RFAL now that that has merged! |
1 similar comment
|
@irfansharif removing this from your review queue since this has become a test only change after #77392. This is RFAL now that that has merged! |
|
friendly ping @dt |
dt
approved these changes
Mar 10, 2022
|
CI failure is TestDockerCLI TFTR! |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an end to end test to ensure that a table excluded
from backup will not holdup GC on its replica even in the presence
of a protected timestamp record covering the replica
From a users point of view, this allows them to mark a table whose
row data will be excluded from backup, and to set that tables gc.ttl
to a very low value. Backups that write PTS records will no longer
holdup GC on such low GC TTL tables.
Fixes: #73536
Release note: None
Release justification: low risk update to new functionality