Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/delegate: avoid extra string->int parsing #77363

Merged
merged 1 commit into from
Mar 7, 2022
Merged

sql/delegate: avoid extra string->int parsing #77363

merged 1 commit into from
Mar 7, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 3, 2022

Release justification: low risk improvement
Release note: None

@rafiss rafiss requested review from RichardJCai and a team March 3, 2022 22:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
delegate: avoid extra string->int parsing
9ddccfb 
Release justification: low risk improvement
Release note: None
@rafiss rafiss force-pushed the improve-numval-show-completions branch from 641da95 to 9ddccfb Compare March 3, 2022 22:42
@rafiss rafiss changed the title delegate: avoid extra string->int parsing sql/delegate: avoid extra string->int parsing Mar 4, 2022
@rafiss
Copy link
Collaborator Author

rafiss commented Mar 7, 2022

tftr!

bors r=otan

@craig
Copy link
Contributor

craig bot commented Mar 7, 2022

Build succeeded:

@craig craig bot merged commit b5bbbed into cockroachdb:master Mar 7, 2022
@rafiss rafiss deleted the improve-numval-show-completions branch March 9, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otan otan otan approved these changes

@RichardJCai RichardJCai Awaiting requested review from RichardJCai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafiss @cockroach-teamcity @otan