-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: skip some slow tests under race #77272
Conversation
These take >1m under race and are now skipped for the race build. Note that TestLearnerSnapshotFailsRollback takes 90s even under ideal conditions, though that is fixed once I get cockroachdb#75248 over the finish line. At that point it probably wouldn't figure prominently as a slow test, but until then it's verrrry slow (>7m, probably since race stuff slows down the longer it runs) so still good to skip it now. https://cockroachlabs.slack.com/archives/C0KB9Q03D/p1646221664032729 Release justification: testing-only change Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these candidates for skip.UnderShort()
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know if you want to attach an issue number to chase these up.
all kvserver tests take over 5s from a quick glance, wonder if we should just skip the suite. but i'll leave that to KV to decide :)
I think we definitely want to run |
Understood, I wish they were a tad more turbo ;) (it's been 2 hours on bors so I'm a little antsy) |
bors r=erikgrinaker
Probably, but I'm not sure if the |
Build failed (retrying...): |
bors r=erikgrinaker |
Build succeeded: |
These take >1m under race and are now skipped for the race build.
Note that TestLearnerSnapshotFailsRollback takes 90s even under ideal
conditions, though that is fixed once I get #75248 over the finish
line. At that point it probably wouldn't figure prominently as a
slow test, but until then it's verrrry slow (>7m, probably since
race stuff slows down the longer it runs) so still good to skip
it now.
https://cockroachlabs.slack.com/archives/C0KB9Q03D/p1646221664032729
Release justification: testing-only change
Release note: None