Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: skip some slow tests under race #77272

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Mar 2, 2022

These take >1m under race and are now skipped for the race build.

Note that TestLearnerSnapshotFailsRollback takes 90s even under ideal
conditions, though that is fixed once I get #75248 over the finish
line. At that point it probably wouldn't figure prominently as a
slow test, but until then it's verrrry slow (>7m, probably since
race stuff slows down the longer it runs) so still good to skip
it now.

https://cockroachlabs.slack.com/archives/C0KB9Q03D/p1646221664032729

Release justification: testing-only change
Release note: None

These take >1m under race and are now skipped for the race build.

Note that TestLearnerSnapshotFailsRollback takes 90s even under ideal
conditions, though that is fixed once I get cockroachdb#75248 over the finish
line. At that point it probably wouldn't figure prominently as a
slow test, but until then it's verrrry slow (>7m, probably since
race stuff slows down the longer it runs) so still good to skip
it now.

https://cockroachlabs.slack.com/archives/C0KB9Q03D/p1646221664032729

Release justification: testing-only change
Release note: None
@tbg tbg requested a review from a team as a code owner March 2, 2022 12:02
@tbg tbg requested a review from otan March 2, 2022 12:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these candidates for skip.UnderShort() too?

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if you want to attach an issue number to chase these up.
all kvserver tests take over 5s from a quick glance, wonder if we should just skip the suite. but i'll leave that to KV to decide :)

@erikgrinaker
Copy link
Contributor

all kvserver tests take over 5s from a quick glance, wonder if we should just skip the suite. but i'll leave that to KV to decide :)

I think we definitely want to run kvserver under race. These are generally integration tests, which is where most races get exposed as we're running a bunch of concurrent components.

@otan
Copy link
Contributor

otan commented Mar 2, 2022

Understood, I wish they were a tad more turbo ;) (it's been 2 hours on bors so I'm a little antsy)

@tbg
Copy link
Member Author

tbg commented Mar 2, 2022

bors r=erikgrinaker

Are these candidates for skip.UnderShort() too?

Probably, but I'm not sure if the -short runs get much airplay and if so what the cutoff is. Let's revisit that during stability when we think about automating the detection of some of these flakyslow tests.

@craig
Copy link
Contributor

craig bot commented Mar 2, 2022

Build failed (retrying...):

@tbg
Copy link
Member Author

tbg commented Mar 3, 2022

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Mar 3, 2022

Build succeeded:

@craig craig bot merged commit da8e4c8 into cockroachdb:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants