Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/sqlproxyccl: skip TestDirectoryConnect under stress #77235

Merged

Conversation

jaylim-crl
Copy link
Collaborator

See #76839.

TestDirectoryConnect seems to be flaking under stress. After some initial
investigations, it is suspected that this may be due to port reuse issues
within the testing environment. We'll skip this test for now, and a TODO
has been added.

Release note: None

Release justification: Low-risk, test only change.

See cockroachdb#76839.

TestDirectoryConnect seems to be flaking under stress. After some initial
investigations, it is suspected that this may be due to port reuse issues
within the testing environment. We'll skip this test for now, and a TODO
has been added.

Release note: None

Release justification: Low-risk, test only change.
@jaylim-crl jaylim-crl requested a review from a team as a code owner March 1, 2022 18:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaylim-crl
Copy link
Collaborator Author

jaylim-crl commented Mar 2, 2022

TFTR!

bors r=JeffSwenson

@craig
Copy link
Contributor

craig bot commented Mar 2, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 3, 2022

Build succeeded:

@craig craig bot merged commit 1304061 into cockroachdb:master Mar 3, 2022
@jaylim-crl jaylim-crl deleted the jay/skip-test-directory-stress branch March 3, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants