Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump Pebble to 40d39da505a5 #77131

Merged

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Feb 28, 2022

40d39da5 db: produce the FlushEnd event after installing readState
cef3f146 compaction: add support for concurrent manual compactions
cb848478 manifest: add methods for extending table bounds
7e5c8ee1 sstable: move block property collector calls to the Writer client goroutine
0e0d279a  internal/keyspan: move MergingIter from internal/rangekey
09203fd9 *: Expose range key iterators through table cache
894b57aa db: correctly set point key bounds in `TestIngest_UpdateSequenceNumber`
6c7f6ed4 base: update IsExclusiveSentinel to account for multiple range key kinds
e0589417 db: add external sstable merging iterator
85162b61 sstable: unify sstable size estimation by using a single abstraction
bac6da8f internal/rangekey: adjust MergingIter interface, return fragment sets
7eb64ae7 Revert "db: add experimental DB.RegisterFlushCompletedCallback"
2c522458 db: remove unnecessary key clones during ingest load
998400e7 db: fix skipped key during Prev at synthetic range key marker
13f8f7ce *: separately track smallest/largest point/range keys in FileMetadata
7449c652 sstable: change index block size estimation to use inflight size
31899eb1 sstable: flush index blocks only from the Writer client goroutine
129bc0d4 internal/rangekey: fix invariant violation during SeekGE(upper-bound)
87ab6c71 db: write range keys to memtables

Release note: None

Release justification: commits merged in Pebble before stability period

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens requested a review from a team February 28, 2022 15:34
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks for pulling in my FlushEnd change :)

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@jbowens jbowens force-pushed the jackson/pebble-master-40d39da505a5 branch from 89fa266 to 9a99c51 Compare February 28, 2022 16:13
@jbowens jbowens requested a review from a team as a code owner February 28, 2022 16:13
@jbowens jbowens force-pushed the jackson/pebble-master-40d39da505a5 branch from 9a99c51 to eb8fdda Compare February 28, 2022 16:33
Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @jbowens)

@jbowens jbowens force-pushed the jackson/pebble-master-40d39da505a5 branch from eb8fdda to 6ca3fe2 Compare February 28, 2022 17:00
Copy link
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 2 stale) (waiting on @jbowens)

Copy link
Contributor

@mufeez-amjad mufeez-amjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, 3 of 4 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 2 stale) (waiting on @jbowens)

@jbowens jbowens force-pushed the jackson/pebble-master-40d39da505a5 branch from 6ca3fe2 to 174abe7 Compare February 28, 2022 18:12
```
40d39da5 db: produce the FlushEnd event after installing readState
cef3f146 compaction: add support for concurrent manual compactions
cb848478 manifest: add methods for extending table bounds
7e5c8ee1 sstable: move block property collector calls to the Writer client goroutine
0e0d279a  internal/keyspan: move MergingIter from internal/rangekey
09203fd9 *: Expose range key iterators through table cache
894b57aa db: correctly set point key bounds in `TestIngest_UpdateSequenceNumber`
6c7f6ed4 base: update IsExclusiveSentinel to account for multiple range key kinds
e0589417 db: add external sstable merging iterator
85162b61 sstable: unify sstable size estimation by using a single abstraction
bac6da8f internal/rangekey: adjust MergingIter interface, return fragment sets
7eb64ae7 Revert "db: add experimental DB.RegisterFlushCompletedCallback"
2c522458 db: remove unnecessary key clones during ingest load
998400e7 db: fix skipped key during Prev at synthetic range key marker
13f8f7ce *: separately track smallest/largest point/range keys in FileMetadata
7449c652 sstable: change index block size estimation to use inflight size
31899eb1 sstable: flush index blocks only from the Writer client goroutine
129bc0d4 internal/rangekey: fix invariant violation during SeekGE(upper-bound)
87ab6c71 db: write range keys to memtables
```

Release note: None

Release justification: commits merged in Pebble before stability period
@jbowens jbowens force-pushed the jackson/pebble-master-40d39da505a5 branch from 174abe7 to 4f29ddb Compare February 28, 2022 19:53
@jbowens
Copy link
Collaborator Author

jbowens commented Feb 28, 2022

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 28, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 1, 2022

Build succeeded:

@craig craig bot merged commit d89e743 into cockroachdb:master Mar 1, 2022
@jbowens jbowens deleted the jackson/pebble-master-40d39da505a5 branch March 1, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants