Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: add telemetry #77108

Merged
merged 1 commit into from
Mar 3, 2022
Merged

ttl: add telemetry #77108

merged 1 commit into from
Mar 3, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented Feb 27, 2022

This commit adds telemetry to row level TTL configuration, as well as
executions of the row level TTL job.

Release note: None

Release justification: low risk high benefit changes to new
functionality

@otan otan requested review from rafiss and a team February 27, 2022 21:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan mentioned this pull request Feb 28, 2022
30 tasks
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @otan)

This commit adds telemetry to row level TTL configuration, as well as
executions of the row level TTL job.

Release note: None

Release justification: low risk high benefit changes to new
functionality
@otan
Copy link
Contributor Author

otan commented Mar 2, 2022

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Mar 3, 2022

Build succeeded:

@craig craig bot merged commit 1304061 into cockroachdb:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants