Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: Augment kafka error messages. #76997

Merged
merged 1 commit into from
Mar 8, 2022
Merged

changefeedccl: Augment kafka error messages. #76997

merged 1 commit into from
Mar 8, 2022

Conversation

miretskiy
Copy link
Contributor

@miretskiy miretskiy commented Feb 24, 2022 •
edited
Loading

Expand kafka error message to include message key as well
as message length for the rejected message.

Release Notes: None
Release Justification: Low impact; usability improvement.

@miretskiy miretskiy requested a review from HonoreDB February 24, 2022 19:01
@miretskiy miretskiy requested a review from a team as a code owner February 24, 2022 19:01
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@shermanCRL
Copy link
Contributor

Very nice.

HonoreDB
HonoreDB approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@HonoreDB HonoreDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)

@miretskiy
Copy link
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Feb 28, 2022
Merge #76997
b6915ee 
76997: changefeedccl: Augment kafka error messages. r=miretskiy a=miretskiy

Expand kafka error message to include message key as well
as message length for the rejected message.

Release Notes: None

Co-authored-by: Yevgeniy Miretskiy <[email protected]>
@craig
Copy link
Contributor

craig bot commented Feb 28, 2022

Build failed:

changefeedccl: Augment kafka error messages.
e2cbb86 
Expand kafka error message to include message key as well
as message length for the rejected message.

Release Notes: None
Release Justification: Low impact; usability improvement.
HonoreDB
HonoreDB approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@HonoreDB HonoreDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)

@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 8, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 8, 2022

Build succeeded:

@craig craig bot merged commit 9deb5c6 into cockroachdb:master Mar 8, 2022
@blathers-crl
Copy link

blathers-crl bot commented Mar 8, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating backport branch refs/heads/blathers/backport-release-21.2-76997: POST https://api.github.com/repos/cockroachlabs/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch 21.2.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@miretskiy miretskiy mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonoreDB HonoreDB HonoreDB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miretskiy @cockroach-teamcity @shermanCRL @HonoreDB