Unary Complement execution has different results when the parameters are different

pkg/sql/logictest/testdata/logic_test/operator

@@ -3,3 +3,47 @@ SELECT |/ -1.0::float
 
 query error cannot take square root of a negative number
 SELECT |/ -1.0::decimal
+
+query I
+SELECT ~-1;
+----
+0
+
+query I
+SELECT ~0;
+----
+-1
+
+query I
+SELECT ~1;
+----
+-2
+
+query I
+SELECT ~2;
+----
+-3
+
+query T
+SELECT ~B'0';
+----
+1
+
+query T
+SELECT ~B'1';
+----
+0
+
+statement error lexical error
+SELECT ~B'2';
+
+statement error ambiguous unary operator
+SELECT ~'0';
+
+statement error ambiguous unary operator
+SELECT ~'1';
+
+query I
+SELECT ~2;
+----
+-3

pkg/sql/sem/tree/overload.go

@@ -750,13 +750,24 @@ func typeCheckOverloadedExprs(
 		// The fourth heuristic is to prefer candidates that accepts the "best"
 		// mutual type in the resolvable type set of all constants.
 		if bestConstType, ok := commonConstantType(s.exprs, s.constIdxs); ok {
+			// In case all overloads are filtered out at this step,
+			// keep track of previous overload indexes to return ambiguous error (>1 overloads)
+			// instead of unsupported error (0 overloads) when applicable.
+			prevOverloadIdxs := s.overloadIdxs
 			for _, i := range s.constIdxs {
 				s.overloadIdxs = filterOverloads(s.overloads, s.overloadIdxs,
 					func(o overloadImpl) bool {
 						return o.params().GetAt(i).Equivalent(bestConstType)
 					})
 			}
 			if ok, typedExprs, fns, err := checkReturn(ctx, semaCtx, &s); ok {
+				if len(fns) == 0 {
+					var overloadImpls []overloadImpl
+					for i := range prevOverloadIdxs {
+						overloadImpls = append(overloadImpls, s.overloads[i])
+					}
+					return typedExprs, overloadImpls, err
+				}
 				return typedExprs, fns, err
 			}
 			if homogeneousTyp != nil {

pkg/sql/sem/tree/overload_test.go

@@ -187,7 +187,7 @@ func TestTypeCheckOverloadedExprs(t *testing.T) {
 		{nil, []Expr{intConst("1")}, []overloadImpl{unaryIntFn, unaryIntFn}, ambiguous, false},
 		{nil, []Expr{intConst("1")}, []overloadImpl{unaryIntFn, unaryFloatFn}, unaryIntFn, false},
 		{nil, []Expr{decConst("1.0")}, []overloadImpl{unaryIntFn, unaryDecimalFn}, unaryDecimalFn, false},
-		{nil, []Expr{decConst("1.0")}, []overloadImpl{unaryIntFn, unaryFloatFn}, unsupported, false},
+		{nil, []Expr{decConst("1.0")}, []overloadImpl{unaryIntFn, unaryFloatFn}, ambiguous, false},
 		{nil, []Expr{intConst("1")}, []overloadImpl{unaryIntFn, binaryIntFn}, unaryIntFn, false},
 		{nil, []Expr{intConst("1")}, []overloadImpl{unaryFloatFn, unaryStringFn}, unaryFloatFn, false},
 		{nil, []Expr{intConst("1")}, []overloadImpl{unaryStringFn, binaryIntFn}, unsupported, false},
@@ -249,7 +249,7 @@ func TestTypeCheckOverloadedExprs(t *testing.T) {
 		{nil, []Expr{NewDInt(1), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, binaryIntFn, false},
 		{nil, []Expr{NewDFloat(1), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, unsupported, false},
 		{nil, []Expr{intConst("1"), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, binaryIntFn, false},
-		{nil, []Expr{decConst("1.0"), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, unsupported, false}, // Limitation.
+		{nil, []Expr{decConst("1.0"), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, ambiguous, false}, // Limitation.
 		{types.Date, []Expr{NewDInt(1), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, binaryIntDateFn, false},
 		{types.Date, []Expr{NewDFloat(1), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, unsupported, false},
 		{types.Date, []Expr{intConst("1"), placeholder(1)}, []overloadImpl{binaryIntFn, binaryIntDateFn}, binaryIntDateFn, false},

pkg/sql/sem/tree/type_check_test.go

@@ -244,7 +244,7 @@ func TestTypeCheckError(t *testing.T) {
 		expr     string
 		expected string
 	}{
-		{`'1' + '2'`, `unsupported binary operator:`},
+		{`'1' + '2'`, `ambiguous binary operator:`},
 		{`'a' + 0`, `unsupported binary operator:`},
 		{`1.1 # 3.1`, `unsupported binary operator:`},
 		{`~0.1`, `unsupported unary operator:`},