Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttljob: add controls to pause TTL jobs #76835

Merged
merged 3 commits into from
Feb 23, 2022
Merged

ttljob: add controls to pause TTL jobs #76835

merged 3 commits into from
Feb 23, 2022

Conversation

otan
Copy link
Contributor

@otan otan commented Feb 21, 2022

See individual commits for details.

@otan otan requested review from rafiss and a team February 21, 2022 03:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan mentioned this pull request Feb 21, 2022
Closed
30 tasks
@otan otan force-pushed the feature_flag branch 6 times, most recently from 4e2ea6e to 779c309 Compare February 22, 2022 11:09
rafiss
rafiss approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! had some optional nits and a question

pkg/sql/ttl/ttljob/ttljob.go Outdated Show resolved Hide resolved
pkg/sql/ttl/ttljob/ttljob.go Outdated Show resolved Hide resolved
pkg/sql/ttl/ttljob/ttljob.go Show resolved Hide resolved
otan added 2 commits February 23, 2022 07:55
@otan
ttljob: add cluster setting for disabling TTL job
0da0874 
This commit disables TTL job execution if the CLUSTER SETTING
sql.ttl.job.enabled is set to false.

Release note: None
@otan
ttljob: introduce ttl_pause
a99be46 
This commit introduces ttl_pause as a table storage parameter, pausing
TTL job for only the given table.

Release note: None
@otan
Copy link
Contributor Author

otan commented Feb 22, 2022

thanks!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Feb 22, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Build failed (retrying...):

@otan
Copy link
Contributor Author

otan commented Feb 23, 2022

bors r-

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Canceled.

@otan
Copy link
Contributor Author

otan commented Feb 23, 2022

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 23, 2022

Build succeeded:

@craig craig bot merged commit 5522769 into cockroachdb:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@otan @cockroach-teamcity @rafiss