spanconfigsqltranslator,jobsprotectedts: add ignore_if_excluded_from_backup to SpanConfig
#76831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
reviewed
Feb 22, 2022
pkg/spanconfig/spanconfigsqltranslator/protectedts_state_reader.go
Outdated
Show resolved
Hide resolved
adityamaru
force-pushed
the
plumb-pts-backup
branch
from
6655925 to
07c4edf
Compare
adityamaru
force-pushed
the
plumb-pts-backup
branch
2 times, most recently
from
ba7a2d6 to
e6208ed
Compare
…backup to SpanConfig This change is a follow up to cockroachdb#75451 which taught ExportRequests to noop on ranges marked as exclude_data_from_backup. This change This diff does two things: - It adds an `ignore_if_excluded_from_backup` bit to ptpb.Target that is set on PTS records written by backup schedules and jobs. - It adds an `ignore_if_excluded_from_backup` bit to the ProtectionPolicy that is shipped to KV as part of the SpanConfig. In a follow up PR, this bit on the SpanConfig will be used in conjunction with `exclude_data_from_backup` to decide whether or not to ignore the ProtectionPolicy when making GC decisions on a span. All other consumers of PTS records will default to setting this bit to false, and so their ProtectionPolicies will always influence GC even if `exclude_data_from_backup` is set to true. Informs: cockroachdb#73536 Release note: None
adityamaru
force-pushed
the
plumb-pts-backup
branch
from
e6208ed to
0e7034c
Compare
|
@irfansharif do you want to have a quick look at this? Most of the spanconfig changes are to how we print DD test output. |
irfansharif
approved these changes
Feb 24, 2022
|
TFTRs! bors r=dt,irfansharif |
|
Build failed (retrying...): |
|
Build succeeded: |
6 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow up to #75451 which taught ExportRequests
to noop on ranges marked as exclude_data_from_backup. This change
This diff does two things:
It adds an
ignore_if_excluded_from_backupbit to ptpb.Target that is seton PTS records written by backup schedules and jobs.
It adds an
ignore_if_excluded_from_backupbit to the ProtectionPolicy thatis shipped to KV as part of the SpanConfig.
In a follow up PR, this bit on the SpanConfig will be used in conjunction with
exclude_data_from_backupto decide whether or not to ignore the ProtectionPolicywhen making GC decisions on a span. All other consumers of PTS records will
default to setting this bit to false, and so their ProtectionPolicies will always
influence GC even if
exclude_data_from_backupis set to true.Informs: #73536
Release note: None