storage: Temporarily disable preemptive snapshots #7674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#7659 Updates cockroachdb#7600 Updates cockroachdb#7619
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
|
LGTM. Interesting that we used SendAsync (I guess there isn't a good way to do a blocking send) before. |
|
Yeah, we don't currently have a way to do a synchronous send. My hope for raft transport errors (#5789) was that we would get a return stream that we could use for acknowledging snapshots, but #7534 took a different strategy. We may need to revisit that (for this reason in addition to the goroutine concerns). |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7659
Updates #7600
Updates #7619
This change is