ttljob: paginate ranges when doing TTL #76726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
range_batch
branch
2 times, most recently
from
c85a8ad to
d16ada0
Compare
rafiss
approved these changes
Feb 21, 2022
| @@ -317,7 +317,11 @@ func TestRowLevelTTLJobRandomEntries(t *testing.T) { | |||
| }) | |||
| defer cleanupFunc() | |||
|
|
|||
| rangeBatchSize := 1 + rng.Intn(3) | |||
There was a problem hiding this comment.
if the default is 100, should the test be closer to that?
There was a problem hiding this comment.
we used a smaller number here here because we have less ranges (maximum of ~8).
| @@ -317,7 +317,11 @@ func TestRowLevelTTLJobRandomEntries(t *testing.T) { | |||
| }) | |||
| defer cleanupFunc() | |||
|
|
|||
| rangeBatchSize := 1 + rng.Intn(3) | |||
| t.Logf("range batch size: %d", rangeBatchSize) | |||
There was a problem hiding this comment.
random thought - we should have one place to randomize + log all the TTL settings
There was a problem hiding this comment.
there is more or less this above -- it's just this is the only one randomised by a cluster setting
|
bors r=rafiss thanks! |
|
Canceled. |
|
bors r=rafiss |
craig bot
pushed a commit
that referenced
this pull request
Feb 22, 2022
76726: ttljob: paginate ranges when doing TTL r=rafiss a=otan This commit batches ranges instead of scanning them in all at once. The range batch size is controlled by the cluster setting `sql.ttl.range_batch_size`. I don't anticipate this needing to be controlled per table. Release note: None Co-authored-by: Oliver Tan <[email protected]>
|
Build failed: |
This commit batches ranges instead of scanning them in all at once. The range batch size is controlled by the cluster setting `sql.ttl.range_batch_size`. I don't anticipate this needing to be controlled per table. Release note: None
|
bors r=rafiss |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit batches ranges instead of scanning them in all at once. The
range batch size is controlled by the cluster setting
sql.ttl.range_batch_size. I don't anticipate this needing to becontrolled per table.
Release note: None