tenantcostcontrol: change settings to TenantReadOnly #76680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the advertised `TenantReadOnly` semantics, changes the `kv.protectedts.reconciliation.interval` setting to `TenantReadOnly`, and adds some relevant tests. Note that the settings watcher already ignores any values for `TenantReadOnly` variables in the system.settings table. This commit includes a test for that. Release note: None
This commit changes the settings relevant for RU accounting and limiting to `TenantReadOnly`. The tenant cost model values are now used (instead of always using the default values). The range of values for `tenant_cpu_usage_allowance` is extended since we no longer have to worry about the tenant bumping it up. Release note: None
|
This change is |
ajwerner
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajstorm and @dt)
|
I added a commit that fixes the use of settings in the jobsprotectedts tests. CC @adityamaru |
This commit fixes these tests to set these settings on the host cluster as well as on the tenant. Release note: None
RaduBerinde
force-pushed
the
tenant-read-only
branch
from
59de7de to
f331966
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tenant settings: implement TenantReadOnly semantics
This commit implements the advertised
TenantReadOnlysemantics,changes the
kv.protectedts.reconciliation.intervalsetting toTenantReadOnly, and adds some relevant tests.Note that the settings watcher already ignores any values for
TenantReadOnlyvariables in thesystem.settingstable. This commitincludes a test for that.
Release note: None
tenantcostcontrol: change settings to TenantReadOnly
This commit changes the settings relevant for RU accounting and
limiting to
TenantReadOnly. The tenant cost model values are nowused (instead of always using the default values). The range of values
for
tenant_cpu_usage_allowanceis extended since we no longer haveto worry about the tenant bumping it up.
Release note: None