Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: fix topological sort for SHOW CREATE ALL #76639

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 16, 2022

fixes #76077

Release note (bug fix): Fixed an error that could sometimes happen when
sorting the output of the SHOW CREATE ALL TABLES command.

@rafiss rafiss requested review from RichardJCai and a team February 16, 2022 02:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @RichardJCai)


pkg/sql/sem/builtins/show_create_all_tables_builtin_test.go, line 29 at r1 (raw file):

	ctx := context.Background()
	monitor := mon.NewMonitor(

nit: you can use execinfra.NewTestMemMonitor.

Copy link
Collaborator Author

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tftr!

bors r=otan

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @RichardJCai)


pkg/sql/sem/builtins/show_create_all_tables_builtin_test.go, line 29 at r1 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: you can use execinfra.NewTestMemMonitor.

done

@craig
Copy link
Contributor

craig bot commented Feb 16, 2022

Build failed (retrying...):

@yuzefovich
Copy link
Member

My suggestion created an import cycle :/

bors r-

@craig
Copy link
Contributor

craig bot commented Feb 16, 2022

Canceled.

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 16, 2022

My suggestion created an import cycle :/

ah i didn't notice because using ./dev generate bazel worked and i thought that would detect it.

Release note (bug fix): Fixed an error that could sometimes happen when
sorting the output of the SHOW CREATE ALL TABLES command.
@rafiss
Copy link
Collaborator Author

rafiss commented Feb 16, 2022

bors r=otan

@craig
Copy link
Contributor

craig bot commented Feb 16, 2022

Build succeeded:

@craig craig bot merged commit 4996177 into cockroachdb:master Feb 16, 2022
@blathers-crl
Copy link

blathers-crl bot commented Feb 16, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 984d219 to blathers/backport-release-21.2-76639: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 16, 2022

blathers backport 21.2

@blathers-crl
Copy link

blathers-crl bot commented Feb 16, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 984d219 to blathers/backport-release-21.2-76639: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: v21.2.4: show_create_all_tables_builtin failed. len(ids): 62 not equal to len(topologicallySortedIDs): 63
4 participants