-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builtins: fix topological sort for SHOW CREATE ALL #76639
Conversation
a418484
to
7861c12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @RichardJCai)
pkg/sql/sem/builtins/show_create_all_tables_builtin_test.go, line 29 at r1 (raw file):
ctx := context.Background() monitor := mon.NewMonitor(
nit: you can use execinfra.NewTestMemMonitor
.
7861c12
to
4df0bad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tftr!
bors r=otan
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @RichardJCai)
pkg/sql/sem/builtins/show_create_all_tables_builtin_test.go, line 29 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: you can use
execinfra.NewTestMemMonitor
.
done
Build failed (retrying...): |
My suggestion created an import cycle :/ bors r- |
Canceled. |
ah i didn't notice because using |
Release note (bug fix): Fixed an error that could sometimes happen when sorting the output of the SHOW CREATE ALL TABLES command.
4df0bad
to
984d219
Compare
bors r=otan |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 984d219 to blathers/backport-release-21.2-76639: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
blathers backport 21.2 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 984d219 to blathers/backport-release-21.2-76639: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
fixes #76077
Release note (bug fix): Fixed an error that could sometimes happen when
sorting the output of the SHOW CREATE ALL TABLES command.