ttljob: implement a delete based rate limit #76615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
rate_limit
branch
3 times, most recently
from
0ce7660 to
9eaf2d5
Compare
rafiss
approved these changes
Feb 17, 2022
pkg/sql/ttl/ttljob/ttljob.go
Outdated
| @@ -149,6 +158,12 @@ func (t rowLevelTTLResumer) Resume(ctx context.Context, execCtx interface{}) err | |||
| rangeConcurrency := getRangeConcurrency(p.ExecCfg().SV(), ttlSettings) | |||
| selectBatchSize := getSelectBatchSize(p.ExecCfg().SV(), ttlSettings) | |||
| deleteBatchSize := getDeleteBatchSize(p.ExecCfg().SV(), ttlSettings) | |||
| deleteRateLimit := getDeleteRateLimit(p.ExecCfg().SV(), ttlSettings) | |||
| deleteRateLimiter := quotapool.NewRateLimiter( | |||
| "ttl", | |||
This commit introduces a delete based rate limit for TTL. It can be configured by the `ttl_delete_rate_limit` storage parameter, but defaults to the value in `sql.ttl.default_delete_rate_limit` (if zero, assume no rate limit). Release note: None
|
done! bors r=rafiss |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r=rafiss |
|
Build failed: |
|
bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(only last commit matters)
This commit introduces a delete based rate limit for TTL. It can be
configured by the
ttl_delete_rate_limitstorage parameter, butdefaults to the value in
sql.ttl.default_delete_rate_limit(if zero,assume no rate limit).
Release note: None