gen/genbzl: general improvements #76550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/fix-up-genbzl
branch
from
09a4221 to
b3bf24f
Compare
rickystewart
approved these changes
Feb 15, 2022
This change does a few things: * It reworks the queries in terms of eachother in-memory. This is better than the previous iteration whereby it'd generate the results and then rely on the output of that query. Instead, we just build up bigger query expressions and pass them to bazel using the --query_file flag. * It avoids exploring the pkg/ui directory (and the pkg/gen directory) because those can cause problems. The pkg/ui directory ends up bringing in npm, which hurts. * It stops rewriting the files before executing the queries. It no longer needs to rewrite them up front because they aren't referenced by later queries. * It removes the excluded target which was problematic because those files weren't properly visible. Fixes cockroachdb#76521 Fixes cockroachdb#76503 Release note: None
ajwerner
force-pushed
the
ajwerner/fix-up-genbzl
branch
from
b3bf24f to
80b48cf
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does a few things:
the previous iteration whereby it'd generate the results and then rely on
the output of that query. Instead, we just build up bigger query expressions
and pass them to bazel using the --query_file flag.
those can cause problems. The pkg/ui directory ends up bringing in npm,
which hurts.
needs to rewrite them up front because they aren't referenced by later
queries.
weren't properly visible.
Fixes #76521
Fixes #76503
Release note: None