Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: add rehome_row to DistSQLBlocklist #76544

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 14, 2022

fixes #76153

This builtin always needs to run on the gateway node.

Release note: None

This builtin always needs to run on the gateway node.

Release note: None
@rafiss rafiss requested review from mgartner and a team February 14, 2022 22:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justice approval

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 15, 2022

tftr!

bors r=mgartner,otan

@craig craig bot merged commit 3cb7eb0 into cockroachdb:master Feb 15, 2022
@craig
Copy link
Contributor

craig bot commented Feb 15, 2022

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Feb 15, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 389dcef to blathers/backport-release-21.2-76544: POST https://api.github.com/repos/cockroachlabs/cockroach/merges: 403 Resource not accessible by integration []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rafiss rafiss deleted the rehome-row-distsql-blocklist branch February 15, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: add rehome_row() builtin to DistsqlBlocklist
4 participants