-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add response admission control to tableWriterBase.finalize #76343
sql: add response admission control to tableWriterBase.finalize #76343
Conversation
This was overlooked in the previous instrumentation that only did response admission in tableWriterBase.flushAndStartNewBatch, which is only exercised when there are multiple batches. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing we want to backport this?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @sumeerbhola)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTRs!
I've added the backport label -- probably worth doing.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @sumeerbhola)
bors r+ |
Build failed (retrying...): |
Build succeeded: |
This was overlooked in the previous instrumentation that only
did response admission in tableWriterBase.flushAndStartNewBatch,
which is only exercised when there are multiple batches.
Release note: None