Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: introduce system.tenant_settings table #76313

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

ajwerner
Copy link
Contributor

@ajwerner ajwerner commented Feb 9, 2022

Part of implementing the multi-tenant cluster settings RFC #73349. I was planning to post it along with more of the implementation but I'm posting it earlier for visibility, in case we need to make decisions related to system table IDs.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner ajwerner force-pushed the ajwerner/tenant-settings-table branch 2 times, most recently from 455cba0 to 3ba6e1d Compare February 9, 2022 19:13
@ajwerner ajwerner force-pushed the ajwerner/tenant-settings-table branch from 3ba6e1d to d7e7865 Compare February 9, 2022 20:11
@ajwerner ajwerner marked this pull request as ready for review February 9, 2022 21:25
@ajwerner ajwerner requested a review from a team February 9, 2022 21:25
@ajwerner ajwerner requested review from a team as code owners February 9, 2022 21:25
@ajwerner ajwerner requested a review from a team February 9, 2022 21:25
@ajwerner ajwerner requested a review from a team as a code owner February 9, 2022 21:25
@ajwerner ajwerner requested review from shermanCRL and RaduBerinde and removed request for a team and shermanCRL February 9, 2022 21:25
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Many thanks for getting this done!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@ajwerner
Copy link
Contributor Author

ajwerner commented Feb 9, 2022

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 10, 2022

Build succeeded:

@craig craig bot merged commit 0fdf716 into cockroachdb:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants