Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix slice bounds panic #76291

Merged
merged 1 commit into from
Feb 9, 2022
Merged

dev: fix slice bounds panic #76291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -euo pipefail

# Bump this counter to force rebuilding `dev` on all machines.
DEV_VERSION=13
DEV_VERSION=14

THIS_DIR=$(cd "$(dirname "$0")" && pwd)
BINARY_DIR=$THIS_DIR/bin/dev-versions
Expand Down
9 changes: 8 additions & 1 deletion pkg/cmd/dev/io/os/os.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,14 @@ func (o *OS) ReadFile(filename string) (string, error) {
// WriteFile wraps around ioutil.ReadFile, writing the given contents to
// the given file on disk.
func (o *OS) WriteFile(filename, contents string) error {
command := fmt.Sprintf("echo %q > %s", strings.TrimSpace(contents[:10]), filename)
var command string
{
commandContents := contents
if len(commandContents) > 10 {
commandContents = commandContents[:10] // keeps the logging manageable
}
command = fmt.Sprintf("echo %q > %s", strings.TrimSpace(commandContents), filename)
}
o.logger.Print(command)

_, err := o.Next(command, func() (output string, err error) {
Expand Down