Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: remove TODOs about bytea/float cast volatility #76194

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 7, 2022

These comments aren't needed, since the current cast volatility is
correct, as far as I can tell.

We might want to report this as a bug in Postgres if it describes these
casts as immutable incorrectly.

Release note: None

These comments aren't needed, since the current cast volatility is
correct, as far as I can tell.

We might want to report this as a bug in Postgres if it describes these
casts as immutable incorrectly.

Release note: None
@rafiss rafiss requested a review from mgartner February 7, 2022 19:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This does look like a bug in Postgres. I'll report it.

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 7, 2022

bors r=mgartner

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 7, 2022

tftr! and for reporting it to them

@craig
Copy link
Contributor

craig bot commented Feb 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 8, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 8, 2022

Build succeeded:

@craig craig bot merged commit a7b1c17 into cockroachdb:master Feb 8, 2022
@mgartner
Copy link
Collaborator

mgartner commented Feb 8, 2022

@rafiss rafiss deleted the remove-cast-todo branch February 10, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants