kvserver: move raft.proto to kvserverpb #76113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
confchangecontext
branch
from
9fec14b to
23bb219
Compare
erikgrinaker
approved these changes
Feb 5, 2022
I'm starting to type code for cockroachdb#75729 and it's clear immediately that we shouldn't have these protos in the `kvserver` package as this will make dependency cycles hard to avoid. We've long introduced the `kvserverpb` package, but simply didn't pull all the protos into it. This commit moves `raft.proto` to `kvserverpb`. There's still a bit of protobuf left in `api.proto`, but that can be handled separately. Release note: None
tbg
force-pushed
the
confchangecontext
branch
from
23bb219 to
7051448
Compare
|
bors r=erikgrinaker |
|
Build succeeded: |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Feb 6, 2022
This is similar to cockroachdb#76113 in that it prevents import cycles in cockroachdb#75729. We don't want the code moved here to necessarily stay in `kvserverbase`, but that is a good place for now. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Feb 6, 2022
76120: kvserver: move raft version encoding to `kvserverbase` r=erikgrinaker a=tbg This is similar to #76113 in that it prevents import cycles in #75729. We don't want the code moved here to necessarily stay in `kvserverbase`, but that is a good place for now. Release note: None Co-authored-by: Tobias Grieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kvserver: move raft.proto to kvserverpb
I'm starting to type code for #75729 and it's clear immediately
that we shouldn't have these protos in the
kvserverpackageas this will make dependency cycles hard to avoid.
We've long introduced the
kvserverpbpackage, but simplydidn't pull all the protos into it.
This commit moves
raft.prototokvserverpb.There's still a bit of protobuf left in
api.proto, butthat can be handled separately (#76114)
Release note: None