roachprod: Make it possible to specify file descriptor limit. #76076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
srosenberg
requested changes
Feb 4, 2022
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @miretskiy and @petermattis)
pkg/roachprod/config/config.go, line 77 at r1 (raw file):
// DefaultNumFilesLimit is the default limit on the number of files that can // be opened by the process. DefaultNumFilesLimit = 65 << 10
I think it's safe to bump the default to 65 << 13. It would be preferred in most cases since detecting fd exhaustion is not always immediate. In cases, where a smaller/higher value is preferred, CLI is used for explicit override.
srosenberg
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Reviewable status:
Add a `--num-files-limit` flag to roachprod start command to change the default file descriptor limit for cockroach process. Release Notes: None
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--num-files-limitflag to roachprod start commandto change the default file descriptor limit for cockroach process.
Release Notes: None