sql: thread WriteAtRequestTimestamp through BackfillerSpec #76064
Conversation
This change was pulled out of the index backfiller PR (cockroachdb#73878). It threads the new WriteAtRequestTimestamp option supported by AddSSTable into the bulk processor. In this PR nothing sets this to true, so it should be a no-op, but it means one less file to keep rebasing when people steal my integer. Release note: None
|
This change is |
|
Probably want to wait on this; we're changing the KV API to combine WriteAtRequestTimestamp and SSTTimestamp |
|
@dt Alrighty, I'll keep an eye out for that. Thanks! |
|
Alternatively, you might be able to sneak this in before @erikgrinaker's change and then let him update it at the same time. Just need to serialize one way or the other. |
Yeah, either is fine with me. I plan on getting that done this weekend. |
|
Let's just wait if it is going to change anyway. |
|
For posterity, this was completed as part of the larger backfiller change, so we're happily writing at request timestamp (nearly) everywhere now. |
This change was pulled out of the index backfiller PR (#73878). It
threads the new WriteAtRequestTimestamp option supported by AddSSTable
into the bulk processor.
In this PR nothing sets this to true, so it should be a no-op, but it
means one less file to keep rebasing when people steal my integer.
Release note: None