backupccl: bump file buffer size to 128MiB but with dynamic growth #75988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Feb 3, 2022
adityamaru
force-pushed
the
incrementally-reserve-file-buf
branch
2 times, most recently
from
f0155e0 to
0545bcc
Compare
This change bumps the `bulkio.backup.merge_file_buffer_size` value to 128MiB from its previous default of 16MiB. This setting determines the maximum byte size of ssts that can be buffered during a backup before the queue needs to be flushed. Instead of always using 128MiB, we incrementally grow the boundaccount associated with the backup processor from 32MiB to the cluster settings value, in increments of 32MiB. Release note (sql change): `bulkio.backup.merge_file_buffer_size` default value has been changed from 16MiB to 128MiB. This value determines the maximum byte size of SSTs that we buffer before forcing a flush during a backup.
adityamaru
force-pushed
the
incrementally-reserve-file-buf
branch
from
0545bcc to
3f9f470
Compare
|
bazel failure is unrelated, timeout in TFTR! bors r=dt |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change bumps the
bulkio.backup.merge_file_buffer_sizevalueto 128MiB from its previous default of 16MiB. This setting determines
the maximum byte size of ssts that can be buffered during a backup
before the queue needs to be flushed.
Instead of always using 128MiB, we incrementally grow the
boundaccount associated with the backup processor from 32MiB
to the cluster settings value, in increments of 32MiB.
Release note (sql change):
bulkio.backup.merge_file_buffer_sizedefault value has been changed from 16MiB to 128MiB. This value determines
the maximum byte size of SSTs that we buffer before forcing a flush
during a backup.