bazel: avoid stamping --config=dev builds #75976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used with a remote build cache, these stamps (despite being marked as volatile), induce an unnecessary golink step when switching back and forth between branches. See bazelbuild/bazel#10075. Opting out here shaves a few precious seconds if the previously built binary is already available. Release note: None
|
This change is |
rickystewart
requested changes
Feb 3, 2022
| @@ -46,7 +46,6 @@ build:crosslinuxarm --config=cross | |||
| build:devdarwinx86_64 --platforms=//build/toolchains:darwin_x86_64 | |||
| build:devdarwinx86_64 --config=dev | |||
| build:dev --define cockroach_bazel_dev=y | |||
| build:dev --stamp --workspace_status_command=./build/bazelutil/stamp.sh | |||
There was a problem hiding this comment.
Two problems with this:
- In my testing,
cockroachbinaries can't start properly if they don't have the various stamped variables. You should be able to trivially reproduce this, but let me know if you can't. You can make this PR mergeable by removing those checks fromcockroach(maybe only fordevbuilds if you need to?) dev doctorwill fail if you delete this line without making any other changes.
|
Not having time to follow up, I'll try again some other day. |
|
Subsumed by #79360. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with a remote build cache, these stamps (despite being marked
as volatile), induce an unnecessary golink step when switching back and
forth between branches. See
bazelbuild/bazel#10075. Opting out here shaves
a few precious seconds if the previously built binary is already
available.
Release note: None
Jira issue: CRDB-14749