Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: address util.log.logcrash package rename #75865

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

rail
Copy link
Member

@rail rail commented Feb 2, 2022

After util.log was renamed to util.log.logcrash, the build system
stopped updating the Sentry environment variable properly. Instead of
setting it to the release version, it was falling back to the default
"development" value. As a result, all Sentry reports went to the
development environment bucket.

This patch addresses the name change.

Release note: None

After `util.log` was renamed to `util.log.logcrash`, the build system
stopped updating the Sentry environment variable properly. Instead of
setting it to the release version, it was falling back to the default
"development" value. As a result, all Sentry reports went to the
development environment bucket.

This patch addresses the name change.

Release note: None
@rail rail added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-build-system labels Feb 2, 2022
@rail rail requested review from knz and rickystewart February 2, 2022 16:18
@rail rail self-assigned this Feb 2, 2022
@rail rail requested a review from a team as a code owner February 2, 2022 16:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh WOW
very nice find and ... 🤦 on my side 😭

we'll want to backport this all the way to the earliest stable release that has the package rename (that would be v21.1)

@rail
Copy link
Member Author

rail commented Feb 2, 2022

blathers backport 21.1 21.2

@blathers-crl
Copy link

blathers-crl bot commented Feb 2, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 235f9d0 to blathers/backport-release-21.1-75865: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rafiss
Copy link
Collaborator

rafiss commented Feb 2, 2022

This is great! Does it also help explain why the Sentry->Github issue filer (on zapier) doesn't work since 21.1?

@knz
Copy link
Contributor

knz commented Feb 2, 2022

Does it also help explain why the Sentry->Github issue filer (on zapier) doesn't work since 21.1?

I think that's why rail investigated this :)

@knz
Copy link
Contributor

knz commented Feb 2, 2022

you'll need to do the backport manually for 21.1.

@rail
Copy link
Member Author

rail commented Feb 2, 2022

Does it also help explain why the Sentry->Github issue filer (on zapier) doesn't work since 21.1?

Yes. I see in Sentry we trigger the Zapier webhook only when "environment starts with v".

@rail
Copy link
Member Author

rail commented Feb 2, 2022

bors r=knz

@craig
Copy link
Contributor

craig bot commented Feb 2, 2022

Build succeeded:

@craig craig bot merged commit 88522a3 into cockroachdb:master Feb 2, 2022
@rail rail deleted the crashReportEnv branch February 2, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants