-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: address util.log.logcrash package rename #75865
Conversation
After `util.log` was renamed to `util.log.logcrash`, the build system stopped updating the Sentry environment variable properly. Instead of setting it to the release version, it was falling back to the default "development" value. As a result, all Sentry reports went to the development environment bucket. This patch addresses the name change. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh WOW
very nice find and ... 🤦 on my side 😭
we'll want to backport this all the way to the earliest stable release that has the package rename (that would be v21.1)
blathers backport 21.1 21.2 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 235f9d0 to blathers/backport-release-21.1-75865: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This is great! Does it also help explain why the Sentry->Github issue filer (on zapier) doesn't work since 21.1? |
I think that's why rail investigated this :) |
you'll need to do the backport manually for 21.1. |
Yes. I see in Sentry we trigger the Zapier webhook only when "environment starts with v". |
bors r=knz |
Build succeeded: |
After
util.log
was renamed toutil.log.logcrash
, the build systemstopped updating the Sentry environment variable properly. Instead of
setting it to the release version, it was falling back to the default
"development" value. As a result, all Sentry reports went to the
development environment bucket.
This patch addresses the name change.
Release note: None