types: make WithoutTypeModifier less error prone #75839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithoutTypeModifier previously did not zero out geometry/geography correctly, causing a bug in active record (which I cannot reproduce easily with a test). Nonetheless, this commit fixes that and makes future types less prone to errors when using `WithoutTypeModifier`. Release note: None
|
This change is |
mgartner
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Thanks for improving this!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/types/types_test.go, line 1031 at r1 (raw file):
for _, tc := range testCases { t.Run(tc.t.SQLString(), func(t *testing.T) {
yikes 😬 was this not even running before?
otan
commented
Feb 2, 2022
There was a problem hiding this comment.
bors r=mgartner
Reviewable status:
pkg/sql/types/types_test.go, line 1031 at r1 (raw file):
Previously, mgartner (Marcus Gartner) wrote…
yikes 😬 was this not even running before?
oh it was, this just splits it out into subtests so it was easier to figure out what i broke
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithoutTypeModifier previously did not zero out geometry/geography
correctly, causing a bug in active record (which I cannot reproduce
easily with a test). Nonetheless, this commit fixes that and makes
future types less prone to errors when using
WithoutTypeModifier.Release note: None