sql: de-flake TestRecordBatchSerializerDeserializeMemoryEstimate #75583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Fixes: cockroachdb#73781 When BatchSize was low and each buffer was much smaller than capacity we could end up with newMemorySize more than %33 smaller than original. However the test is just making sure we aren't double counting memory so testing that newMemorySize - originalMemory < 4/3 original. I.e. its okay if it shrinks but we don't want it to be more than %33 bigger. Release note: None
cucaroach
changed the title
yuzefovich
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
pkg/col/colserde/record_batch_test.go, line 344 at r1 (raw file):
// We expect that the original and the new memory sizes are relatively close // to each other, specifically newMemorySize must less than
nit: s/must less/must be less/.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #73781
When BatchSize was low and each buffer was much smaller than capacity
we could end up with newMemorySize more than %33 smaller than original.
However the test is just making sure we aren't double counting memory
so testing that newMemorySize - originalMemory < 4/3 original. I.e.
its okay if it shrinks but we don't want it to be more than %33 bigger.
Release note: None