ui: fix 3rd click on sorting table column #75473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a user clicked the 3rd time on the same column, the page was crashing (Only happening on Statement and Transaction pages). This would happen because on those two pages we need to update when we switch tabs, and the value of sort being set to null was causing the componentDidUpdate being called constantly. Since we always have a sort happening on the table, this commit removes the 3rd option of blank selection. This commit also updates the Session tab to be properly updating the query params when the tab is switched. Fixes cockroachdb#74440 Release note (bug fix): Fix SQL Activity pages crashing when a column was sorted by the 3rd time.
|
This change is |
Azhng
reviewed
Jan 25, 2022
There was a problem hiding this comment.
Ah, nulls is so scary. Is there anywhere we can test this?
Reviewable status:
complete! 0 of 0 LGTMs obtained
maryliag
commented
Jan 25, 2022
There was a problem hiding this comment.
we the change there is not way to test the previous behaviour
Reviewable status:
maryliag
commented
Jan 25, 2022
There was a problem hiding this comment.
*with this change
Reviewable status:
Azhng
approved these changes
Jan 25, 2022
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a user clicked the 3rd time on the same
column, the page was crashing (Only happening on
Statement and Transaction pages). This would happen
because on those two pages we need to update when we switch
tabs, and the value of sort being set to null was
causing the componentDidUpdate being called constantly.
Since we always have a sort happening on the table, this
commit removes the 3rd option of blank selection.
This commit also updates the Session tab to be properly
updating the query params when the tab is switched.
Fixes #74440
Release note (bug fix): Fix SQL Activity pages crashing when
a column was sorted by the 3rd time.