storage: fix EngineComparer ordering of bare suffixes
#75447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For generalized range key support, Pebble now requires bare key suffixes to be comparable with the same ordering as if they had a common user key prefix (see [cockroachdb/pebble#08c5d46c75722b9527c360ca1e7069c0d2286e59](cockroachdb/pebble@08c5d46)). This patch modifies `EngineComparer` to satisfy that requirement. Previously, such suffixes would sort in ascending timestamp order rather than the correct descending order. Release note: None
|
This change is |
jbowens
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
|
bors r=jbowens |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For generalized range key support, Pebble now requires bare key suffixes
to be comparable with the same ordering as if they had a common user key
prefix (see cockroachdb/pebble#08c5d46c75722b9527c360ca1e7069c0d2286e59).
This patch modifies
EngineComparerto satisfy that requirement.Previously, such suffixes would sort in ascending timestamp order
rather than the correct descending order.
Release note: None