util/tracing: skip a few tests under deadlock detector #75439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
As explained in cockroachdb#75423, span reuse is incompatible with the deadlock detector, which flags this reuse as false-positives. That patch generally disabled reuse when running under the test detector. This patch skips a few tests that explicitly ask for span reuse. I'll separately try to improve the deadlock detector such that it can be used with our code. Fixes cockroachdb#75433 Fixes cockroachdb#75488 Release note: None
aayushshah15
approved these changes
Jan 25, 2022
complete! 1 of 0 LGTMs obtained
knz
approved these changes
Jan 25, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #75423, span reuse is incompatible with the deadlock
detector, which flags this reuse as false-positives. That patch
generally disabled reuse when running under the test detector. This
patch skips a few tests that explicitly ask for span reuse.
I'll separately try to improve the deadlock detector such that it can be
used with our code.
Fixes #75433
Fixes #75488
Release note: None